Discussion:
[KDE/Mac] Review Request 123353: [OS X] Make ktimetracker build and fully functional
René J.V. Bertin
2015-04-13 15:29:10 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123353/
-----------------------------------------------------------

Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.


Repository: kdepim


Description
-------

A while ago I created a RR for ktimetracker on OS X (https://git.reviewboard.kde.org/r/119533/) which was either never committed (despite a "Ship It") or which was reverted at a later stage. I therefore re-submit the patch with updates.

I have now a better fix for the failing dynamic_cast in mainwindow.cpp . The cast itself continues to fail despite ensuring that `ktimetrackerpart` is exported. It appears not to be required on OS X, however.
The idle time detection code for OS X has not been changed.


Diffs
-----

ktimetracker/CMakeLists.txt bf7b0ef
ktimetracker/idletimedetector.h 524f739
ktimetracker/idletimedetector.cpp 250dda5
ktimetracker/ktimetrackerpart.h 95da43b
ktimetracker/ktimetrackerpart_export.h PRE-CREATION
ktimetracker/ktimetrackerutility.cpp efeba3a
ktimetracker/mainwindow.cpp 56d4c28

Diff: https://git.reviewboard.kde.org/r/123353/diff/


Testing
-------

On OS X 10.9.5 with kdelibs 4.14.5


Thanks,

René J.V. Bertin
Sandro Knauß
2015-04-14 06:42:49 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123353/#review78915
-----------------------------------------------------------


The patch looks look, but the future of ktimetracker is unclear.
We don't have the capibilities to support ktimetracker anymore, so we won't relase a new version for Qt5.

Further discussion on the kde-***@kde.org.

- Sandro Knauß
Post by René J.V. Bertin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123353/
-----------------------------------------------------------
(Updated April 13, 2015, 3:29 nachm.)
Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.
Repository: kdepim
Description
-------
A while ago I created a RR for ktimetracker on OS X (https://git.reviewboard.kde.org/r/119533/) which was either never committed (despite a "Ship It") or which was reverted at a later stage. I therefore re-submit the patch with updates.
I have now a better fix for the failing dynamic_cast in mainwindow.cpp . The cast itself continues to fail despite ensuring that `ktimetrackerpart` is exported. It appears not to be required on OS X, however.
The idle time detection code for OS X has not been changed.
Diffs
-----
ktimetracker/CMakeLists.txt bf7b0ef
ktimetracker/idletimedetector.h 524f739
ktimetracker/idletimedetector.cpp 250dda5
ktimetracker/ktimetrackerpart.h 95da43b
ktimetracker/ktimetrackerpart_export.h PRE-CREATION
ktimetracker/ktimetrackerutility.cpp efeba3a
ktimetracker/mainwindow.cpp 56d4c28
Diff: https://git.reviewboard.kde.org/r/123353/diff/
Testing
-------
On OS X 10.9.5 with kdelibs 4.14.5
Thanks,
René J.V. Bertin
Marko Käning
2015-04-14 06:47:37 UTC
Permalink
Post by René J.V. Bertin
Post by Sandro Knauß
The patch looks look, but the future of ktimetracker is unclear.
We don't have the capibilities to support ktimetracker anymore, so we won't relase a new version for Qt5.
Very sad.

So, for those who want to use an alternative I can recommend KDAB's charm! :-)


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123353/#review78915
-----------------------------------------------------------
Post by René J.V. Bertin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123353/
-----------------------------------------------------------
(Updated April 13, 2015, 5:29 p.m.)
Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.
Repository: kdepim
Description
-------
A while ago I created a RR for ktimetracker on OS X (https://git.reviewboard.kde.org/r/119533/) which was either never committed (despite a "Ship It") or which was reverted at a later stage. I therefore re-submit the patch with updates.
I have now a better fix for the failing dynamic_cast in mainwindow.cpp . The cast itself continues to fail despite ensuring that `ktimetrackerpart` is exported. It appears not to be required on OS X, however.
The idle time detection code for OS X has not been changed.
Diffs
-----
ktimetracker/CMakeLists.txt bf7b0ef
ktimetracker/idletimedetector.h 524f739
ktimetracker/idletimedetector.cpp 250dda5
ktimetracker/ktimetrackerpart.h 95da43b
ktimetracker/ktimetrackerpart_export.h PRE-CREATION
ktimetracker/ktimetrackerutility.cpp efeba3a
ktimetracker/mainwindow.cpp 56d4c28
Diff: https://git.reviewboard.kde.org/r/123353/diff/
Testing
-------
On OS X 10.9.5 with kdelibs 4.14.5
Thanks,
René J.V. Bertin
Christophe Giboudeaux
2017-11-13 21:40:36 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123353/#review103836
-----------------------------------------------------------



Closing. KTimeTracker is unmaintained

- Christophe Giboudeaux
Post by René J.V. Bertin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123353/
-----------------------------------------------------------
(Updated avr. 13, 2015, 3:29 aprÚs-midi)
Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.
Repository: kdepim
Description
-------
A while ago I created a RR for ktimetracker on OS X (https://git.reviewboard.kde.org/r/119533/) which was either never committed (despite a "Ship It") or which was reverted at a later stage. I therefore re-submit the patch with updates.
I have now a better fix for the failing dynamic_cast in mainwindow.cpp . The cast itself continues to fail despite ensuring that `ktimetrackerpart` is exported. It appears not to be required on OS X, however.
The idle time detection code for OS X has not been changed.
Diffs
-----
ktimetracker/CMakeLists.txt bf7b0ef
ktimetracker/idletimedetector.h 524f739
ktimetracker/idletimedetector.cpp 250dda5
ktimetracker/ktimetrackerpart.h 95da43b
ktimetracker/ktimetrackerpart_export.h PRE-CREATION
ktimetracker/ktimetrackerutility.cpp efeba3a
ktimetracker/mainwindow.cpp 56d4c28
Diff: https://git.reviewboard.kde.org/r/123353/diff/1/
Testing
-------
On OS X 10.9.5 with kdelibs 4.14.5
Thanks,
René J.V. Bertin
René J.V. Bertin
2017-11-13 21:40:40 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123353/
-----------------------------------------------------------

(Updated nov. 13, 2017, 9:40 aprÚs-midi)


Status
------

This change has been discarded.


Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.


Repository: kdepim


Description
-------

A while ago I created a RR for ktimetracker on OS X (https://git.reviewboard.kde.org/r/119533/) which was either never committed (despite a "Ship It") or which was reverted at a later stage. I therefore re-submit the patch with updates.

I have now a better fix for the failing dynamic_cast in mainwindow.cpp . The cast itself continues to fail despite ensuring that `ktimetrackerpart` is exported. It appears not to be required on OS X, however.
The idle time detection code for OS X has not been changed.


Diffs
-----

ktimetracker/CMakeLists.txt bf7b0ef
ktimetracker/idletimedetector.h 524f739
ktimetracker/idletimedetector.cpp 250dda5
ktimetracker/ktimetrackerpart.h 95da43b
ktimetracker/ktimetrackerpart_export.h PRE-CREATION
ktimetracker/ktimetrackerutility.cpp efeba3a
ktimetracker/mainwindow.cpp 56d4c28


Diff: https://git.reviewboard.kde.org/r/123353/diff/1/


Testing
-------

On OS X 10.9.5 with kdelibs 4.14.5


Thanks,

René J.V. Bertin

Loading...