Discussion:
D5825: kcheckpass: Add support in for non-Linux platforms via kevent.
Tobias C. Berner
2017-05-29 07:56:33 UTC
Permalink
tcberner added a reviewer: kde-mac.
tcberner marked 2 inline comments as done.

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac
Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
René J.V. Bertin
2017-05-29 08:21:21 UTC
Permalink
rjvbb added a comment.
I have not yet had time to test it at all :)
Do you actually intend to test this on Mac? I laud and applaud the initiative but I see only one way that the package will ever get used on Mac - providing KWin as a standalone alternative *X11* window manager for use under XQuartz (knowing that XQuartz currently doesn't support compositing). And that's not possible with stock Qt (not until some of us team up to polish my PoC Qt/XCB-on-Mac patches and submit them for upstream incorporation; the Qt guys are likely to accept them as it'd fit with their policy and there might be a "market").

FWIW, funny coincidence, I did manage to build kscreenlocker 5.9.3 on Mac last week, simply #ifdeffing-out parts of the code that where Linux specific or required an X11 KWindowSystem build (I just build the plugin). The screenlocker blacks out the screen but lacking keyboard event support it had to be killed. Or just quit via the native Mac menu item, which kind of defeats the purpose of a screenlocker ;)

FWIW2: if you feel like starting a crusade against linuxisms, please do start with libwayland. It has a number of those (signalfd, epoll) which stand in the way of bringing Wayland to Mac, and there'd definitely be a market for that.

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac
Cc: rjvbb, adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Tobias C. Berner
2017-05-29 08:29:48 UTC
Permalink
tcberner edited the summary of this revision.

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac
Cc: rjvbb, adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Tobias C. Berner
2017-05-29 08:32:24 UTC
Permalink
tcberner added a comment.
Post by René J.V. Bertin
Do you actually intend to test this on Mac?
Nope, I don't have a Mac :) -- but I hoped, that there were some Mac users who could check it on their end too (as you also have kqueue/kevent) -- but I did not know that most of the stuff is not yet ported for Mac.

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac
Cc: rjvbb, adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
René J.V. Bertin
2017-05-29 08:59:58 UTC
Permalink
rjvbb added a comment.
Post by Tobias C. Berner
Post by René J.V. Bertin
Do you actually intend to test this on Mac?
Nope, I don't have a Mac :) -- but I hoped, that there were some Mac users who could check it on their end too (as you also have kqueue/kevent) -- but I did not know that most of the stuff is not yet ported for Mac.
You ought to be able to set up a VM (or build a dual-boot Hackintosh ;)) but there are several reasons why this endeavour is a bit futile on Mac. The most important of which are that Qt and KF5 code in general assume that X11 isn't available (or shouldn't be used) on Mac, and a prevalent apparent attitude among many (or just the most vocal) Plasma devs that Plasma is off-limits on Mac.

But even without those obstacles, the XQuartz X11 environment runs as an "embedded server" inside a standard Aqua session and I don't know of any way to run any other kind of session. Of course you can run an X11 screensaver and/or screenlocker but what's the point if you already have the same functionality in the main session? In fact, the same *but full-featured* functionality; I strongly doubt that an X11 screenlocker will (nor should) provide features to suspend, shutdown/restart the system or login as another user.

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac
Cc: rjvbb, adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
René J.V. Bertin
2017-05-29 09:02:11 UTC
Permalink
rjvbb added a comment.


Already getting updates through kde-mac, no need to receive everything twice.

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac
Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
David Edmundson
2017-05-29 09:10:22 UTC
Permalink
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


OS X is not a supported Plasma platform, BSD is. Whether it works there or not too important.

You can put this in the 5.10 branch for 5.10.1 which is out pretty soon after 5.10

REPOSITORY
R133 KScreenLocker

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac, davidedmundson
Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Tobias C. Berner
2017-05-29 18:08:00 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:c2fd8526c523: kcheckpass: Add support in for non-Linux platforms via kevent. (authored by tcberner).

REPOSITORY
R133 KScreenLocker

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5825?vs=14906&id=14951

REVISION DETAIL
https://phabricator.kde.org/D5825

AFFECTED FILES
CMakeLists.txt
config-kscreenlocker.h.cmake
greeter/authenticator.cpp
kcheckpass/kcheckpass.c

To: tcberner, #freebsd, graesslin, kde-mac, davidedmundson
Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
René J.V. Bertin
2017-05-29 20:13:02 UTC
Permalink
rjvbb added a comment.
Post by David Edmundson
OS X is not a supported Plasma platform, BSD is.
Just for future reference: OS X doesn't have sigwaitinfo() (or the cited alternative).

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac, davidedmundson
Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Martin Flöser
2017-06-14 18:42:27 UTC
Permalink
graesslin added a subscriber: rjvbb.
graesslin added a comment.
Post by René J.V. Bertin
Post by David Edmundson
OS X is not a supported Plasma platform, BSD is.
Just for future reference: OS X doesn't have sigwaitinfo() (or the cited alternative).
Nevertheless OS X is not supported by kscreenlocker and will never be.

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac, davidedmundson
Cc: rjvbb, adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
René J.V. Bertin
2017-06-14 19:03:01 UTC
Permalink
rjvbb added a comment.
Post by Martin Flöser
Nevertheless OS X is not supported by kscreenlocker and will never be.
You got it all wrong, OS X doesn't support kscreenlocking, gna!

(If I were still a fanboy I'd add that it's way too kool to support running most kinds of plasma O:^) )

REPOSITORY
R133 KScreenLocker

REVISION DETAIL
https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin, kde-mac, davidedmundson
Cc: rjvbb, adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Loading...