Discussion:
D7283: WIP: KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too
René J.V. Bertin
2017-08-13 13:25:14 UTC
Permalink
rjvbb created this revision.
rjvbb added a project: Frameworks.

REVISION SUMMARY
As mentioned in https://phabricator.kde.org/D7237, the kioslave helper is also a candidate for being converted to a "nongui" agent.
It thus makes sense to put the helper functions into a shared library, all the more so since kiod5 and kioslave aren't the only helper utilities that should run as agents.

To keep matters simple I've put the new ObjC++ module into libKF5KIO but I think it really should go into KCoreAddons (possibly into a new namespace). Suggestions welcome how to implement that properly!

TEST PLAN
Works as intended on Mac.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D7283

AFFECTED FILES
src/core/CMakeLists.txt
src/core/kio_mac.h
src/core/kio_mac.mm
src/kiod/CMakeLists.txt
src/kiod/kiod_agent.mm
src/kiod/kiod_main.cpp
src/kioslave/kioslave.cpp

To: rjvbb, #frameworks
Cc: #frameworks, kde-mac
René J.V. Bertin
2018-11-13 10:30:01 UTC
Permalink
rjvbb retitled this revision from "WIP: KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too" to "KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too".
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
R241 KIO

REVISION DETAIL
https://phabricator.kde.org/D7283

To: rjvbb, #frameworks
Cc: kde-frameworks-devel, #frameworks, kde-mac, michaelh, ngraham, bruns
Loading...